Skip to content
Jump to bottom

Initialv2 #2

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Initialv2 #2

merged 12 commits into from
Oct 7, 2024
+44 −36

Conversation

morga471
Copy link
Contributor

@morga471 morga471 commented Oct 1, 2024

No description provided.

@morga471 morga471 self-assigned this Oct 1, 2024
mcgin314
mcgin314 suggested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@mcgin314 mcgin314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a way smarter approach to resolving the plan problem than I was thinking. Just need to adjust the one copy/paste typo I noted, otherwise looks good.

main.tf Outdated Show resolved Hide resolved
@morga471 morga471 requested a review from mcgin314 October 7, 2024 16:59
mcgin314
mcgin314 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mcgin314 mcgin314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgin314 mcgin314 merged commit d6fea96 into main Oct 7, 2024
@mcgin314 mcgin314 deleted the initial branch October 7, 2024 18:36
Sign in to join this conversation on GitHub.
Reviewers

@mcgin314 mcgin314 mcgin314 approved these changes

@badra001 badra001 Awaiting requested review from badra001

Assignees

@morga471 morga471

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morga471 @mcgin314